Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release #1000

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Prepare for release #1000

merged 1 commit into from
Aug 23, 2023

Conversation

raphael-proust
Copy link
Collaborator

Version 5.7.0

Don't merge for now

@MisterDA
Copy link
Contributor

MisterDA commented Aug 4, 2023

Can you consider merging #967 before cutting the release?

@raphael-proust
Copy link
Collaborator Author

I'm reticent in including this because it copies some code that's under a different and incompatible license. It's very short and it's the logical thing to do, but still it's the same code.

Something similarish (bigger chunks of code) happened with Eio: ocaml-multicore/eio#352 (comment)

I can think of a few ways solve this, but none seem very satisfactory:

  • merge anyway (but I'm not a lawyer and I don't know if that's ok)
  • create a separate LGPL library which includes just the bit of code we need and link against that from Lwt (but it's a lot of boilerplate)
  • open a PR upstream to make the chunk of code we need be its own function so we can call it (but it's a potentially long process and forces us to depend on newly releases of OCaml)

If you see another alternative or if you can make a good case for one of those, maybe I can merge the PR or another equivalent PR.

@MisterDA
Copy link
Contributor

MisterDA commented Aug 7, 2023

There were a few comments from February on the ocamllabs slack channel suggesting the code snippet was small enough to be merged.
If you're still worried about license considerations, I strongly suggest you merge the related code we know won't be affected, like the failing test. You might then get someone without knowledge of the code snippet (a willing intern? a dedicated hackers' grandmother?) to write a clean-room implementation of it, without looking at the source of the stdlib, with the help of the test. But I'm not a lawyer.

@samwgoldman
Copy link

Now that 5.1.0~rc1 is released, I'd like to give it a try, but we currently can't test because of our dependency on Lwt. Looking forward to a release with compatibility with OCaml 5.1. Thank you!

@raphael-proust
Copy link
Collaborator Author

Now that 5.1.0~rc1 is released, I'd like to give it a try, but we currently can't test because of our dependency on Lwt. Looking forward to a release with compatibility with OCaml 5.1. Thank you!

The release should be merged soon. The PR for it is ocaml/opam-repository#24213

@raphael-proust raphael-proust merged commit 7f8c3f0 into master Aug 23, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants