Fix ux mobile budget page adjustements #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rsdeus
force-pushed
the
fix/ux_mobile_budget_page
branch
from
e8d69c4 to
11cf9f3
Compare
rsdeus
force-pushed
the
fix/ux_mobile_budget_page
branch
from
11cf9f3 to
76ba3af
Compare
froger
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Hi @rsdeus thanks for your PR. Here the code review:
- rename
class_csstocss_class - as all the classes of budget specifies the type (list, card, etc), I suggest you use a
_containersuffix.
Will now check on a live instance for further review.
decidim-budgets/app/views/decidim/budgets/projects/_order.html.erb
Outdated
Show resolved
Hide resolved
decidim-budgets/app/views/decidim/budgets/projects/index.html.erb
Outdated
Show resolved
Hide resolved
rsdeus
changed the title
rsdeus
force-pushed
the
fix/ux_mobile_budget_page
branch
2 times, most recently
from
3250052 to
ea70143
Compare
froger
requested changes
Jan 29, 2025
decidim-budgets/app/views/decidim/budgets/projects/_order.html.erb
Outdated
Show resolved
Hide resolved
rsdeus
force-pushed
the
fix/ux_mobile_budget_page
branch
from
933a06a to
a5254e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
On Mobile, on a Budget page:
📌 Related Issues
https://git.octree.ch/decidim/decidim-nightly/-/issues/86
📷 Screenshots