Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern CSS workshop #763

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Modern CSS workshop #763

merged 3 commits into from
Dec 12, 2024

Conversation

mirisuzanne
Copy link
Member

Description

A trimmed down workshop, focusing on new features.

Should I be covering more of the new stuff, somehow? This still doesn't include:

  • anchor positioning
  • any animation/transition stuff (view transitions, scroll-based animations, discrete animations, transition-to-auto, starting-style, etc)
  • @property (I'd have to get into custom properties)
  • any of the color stuff (light-dark() and color-mix() especially)

Copy link

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..modern-css

Copy link
Contributor

@SondraE SondraE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Smashing Conference link goes to the workshop page on OddSite. Is that because Smashing doesn't have a page on their site yet for this workshop?

Are you planning to update the image? I would recommend a different one so that it's clear at a glance that this is a different workshop than Cascading Style Systems.

@mirisuzanne
Copy link
Member Author

@SondraE

The Smashing Conference link goes to the workshop page on OddSite. Is that because Smashing doesn't have a page on their site yet for this workshop?

Yes, that's right. We can add the link once it exists.

Are you planning to update the image? I would recommend a different one so that it's clear at a glance that this is a different workshop than Cascading Style Systems.

See what you think.

@SondraE
Copy link
Contributor

SondraE commented Dec 12, 2024

@mirisuzanne I really like that new image! It's really eye-catching.

@mirisuzanne mirisuzanne merged commit 6ea4f63 into main Dec 12, 2024
10 checks passed
@mirisuzanne mirisuzanne deleted the modern-css branch December 12, 2024 22:39
@@ -0,0 +1,191 @@
---
feature: workshop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne Does this do anything until we revert #735 (and parts of #736 if we want)? Or maybe we want to feature our own April workshop?

Copy link
Member Author

@mirisuzanne mirisuzanne Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah likely it doesn't do anything currently. I just moved it over from the previous one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the question is whether we want to feature a workshop, or which one we want to feature next? But for now this doesn't hurt anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants