Fix generator with dependencies without generator #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to generate a secret using a secret without generator, an error occurred. And not the assert that was removed. The code was falling on
stringsWithDeps.textClosureMap
and I could not understand what the problem was. If add any generator - all fine.After figuring it out, I first thought I could re-mark the assert, but I thought I could filter out the dependencies. This should not break the order of password generation, because filtered secrets have no dependencies.
Reproduce
Config:
Log