Created version 1.0.0 of HexJSON #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more complete layout description.
|
Hmm... and a comment: I think the maxCoordinates might better be off when it's the minCoordinates, as this is an intuitive natural fit for the origin with most layouts. For axial layouts it still provides the same benefit as maxCoordinates. Anyway, please let me know what you think. Otherwise I'll just go on with adding some things to d3-hexjson. |
…e origin in most cases. Changed version to use only two levels instead of three.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I crated a new version of the specification for HexJSON. This version includes semantic version numbering and a more complete layout description. Using these additions the layout of the map should be unambiguous. I am proposing this extension as a precursor to modifications to the relevant code in d3-hexJSON and hexmaps. Feel free to comment on this proposal.
I created a different branch given the possible impact. However, since this is my first pull request ever it's highly likely that isnt done completely right :). So if you want this done in another way please contact me. My mailadres is on my website.