Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/crypto: More improvements #4124

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

core/crypto: More improvements #4124

wants to merge 13 commits into from
+5,877 −585

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Aug 23, 2024 •
edited
Loading

  • Cleanups/improvements
    • Refactor the blake2 code to use SIMD?
    • (AMD64) Support hardware accelerated SHA-224/SHA-256.
    • Switch to using context-less panic
    • Improve/add benchmarks
  • More algorithms?
    • Add X448
    • AEGIS
    • Deoxys-II
    • Argon2
    • ChaCha8Rng

@Yawning Yawning force-pushed the feature/crypto branch 9 times, most recently from 8450ddd to 26fb0a1 Compare August 30, 2024 19:26
@Yawning Yawning force-pushed the feature/crypto branch 6 times, most recently from b6f512d to 363df33 Compare September 5, 2024 20:26
@Yawning Yawning force-pushed the feature/crypto branch 3 times, most recently from 4198575 to f69bb60 Compare September 15, 2024 22:43
@Yawning Yawning force-pushed the feature/crypto branch 7 times, most recently from 7d37012 to 00e013b Compare September 26, 2024 07:17
@Yawning Yawning force-pushed the feature/crypto branch 4 times, most recently from 6f62ca6 to e8dc9bc Compare October 13, 2024 17:32
@Yawning Yawning force-pushed the feature/crypto branch 4 times, most recently from 6c91c67 to 78d9d75 Compare October 21, 2024 17:40
@Yawning Yawning force-pushed the feature/crypto branch 5 times, most recently from cadf7c9 to d77b40d Compare November 2, 2024 03:29
@Yawning
core/crypto/_aes/hw_intel: Fix comment (NFC)
e579117
@Yawning
core/crypto: Use panic_contextless instead of intrinsics.trap
51e7eb7
@Yawning
core/crypto/chacha20: Misc Simd128 improvements
e23f4aa 
- Detect the RISC-V `v` profile
- Don't bother trying to process 4 blocks at a time if emulated
@Yawning
core/crypto/chacha20poly1305: Add missing assertions
2bd3685
@Yawning
core/crypto: Add rodata annotations (NFC)
0b94cbf
@Yawning
core/crypto/x448: Initial import
9bce3df
@Yawning
core/crypto/aegis: Initial import
383a460
@Yawning
core:crypto/deoxysii: Initial import
a991025
@Yawning
test/benchmarks/crypto: Improve benchmarks
b665ed1 
- Use text/table for results
- Add more benchmarks
@Yawning
core/crypto/sha2: Use hardware SHA224/256 when available (AMD64)
6d93fe3
@Yawning
core/crypto/sha2: Clean up the portable code slightly
d3c4bc2
@Yawning
core/crypto/blake2: Add the ability to easily alter digest size
850c413
@Yawning
core/crypto/argon2id: Initial implementation
384c6c2
jedisct1
jedisct1 reviewed Nov 16, 2024
View reviewed changes
core/crypto/aegis/aegis_impl_hw_intel.odin
st.rate = _RATE_128L

for _ in 0 ..< 10 {
update_hw_128l(st, iv, key)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a bit of performance improvement: since the input is constant, and we don't need to compute a key stream here, the state can be kept in bitsliced form during the initialization rounds. Same for finalization.
In bitsliced form, the rotation of the AES blocks is just a one-bit shift of the bytes.

During AD absorption, you can also keep the state in bitsliced form, and only bitslice the input blocks.

Also for the sbox, there are faster circuits than the Boyar-Peralta: https://eprint.iacr.org/2019/802.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedisct1 jedisct1 jedisct1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yawning @jedisct1