math/linalg add matrix_mul_vector_differ & update matrix_mul_vector #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `matrix_mul_vector_differ` that returns the resulting matrix type. update `matrix_mul_vector` to take the correct types that result in a vector.
gingerBill
reviewed
Oct 29, 2024
core/math/linalg/general.odin
Outdated
Comment on lines
215
to
221
| matrix_mul_vector :: proc "contextless" (a: $A/matrix[$I, $J]$E, b: $B/[J]E) -> (c: B) | ||
| matrix_mul_vector :: proc "contextless" (a: $A/matrix[$I, I]$E, b: $B/[I]E) -> (c: B) | ||
| where !IS_ARRAY(E), IS_NUMERIC(E) #no_bounds_check { | ||
| return a * b | ||
| } | ||
|
|
||
| @(require_results) | ||
| matrix_mul_vector_differ :: proc "contextless" (a: $A/matrix[$I, $J]$E, b: $B/[J]E) -> (c: matrix[I, 1]E) |
There was a problem hiding this comment.
Have you even tested this code to see if it even works?
There was a problem hiding this comment.
Yes but see I missed copying something over. Sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently passing a
maritx[I, J]T&[J]Tto matrix_mul_vector (as the inputs want) results in a type error.Error: Cannot assign value 'a * b' of type 'matrix[2, 1]int' to '[3]int' in return statementAdd matrix_mul_vector_differ that returns the expect resulting matrix
maritx[I, 1]TUpdate matrix_mul_vector to take only take a
maritx[I, I]TThis change shouldn't effect any current use of matrix_mul_vector
Suggested fix for #4433