core:log improvements #4463
Open
core:log improvements #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were various issues with core:log, namely that it would silently use context.allocator behind your back. The api has been changed to allow the user to provide an interface to the creation of file/console logger and multiloggers. Furthermore updated the language used to be more consistent with odin's naming scheme. This renames create -> make and detroy -> delete. The old names and behaviour have been deprecated and have had their behaviour retained. Additionally support for os2 has been added.
|
Looks like test runner got stuck |
flysand7
reviewed
Nov 7, 2024
gingerBill
reviewed
Nov 8, 2024
| @@ -6,8 +6,11 @@ import "core:encoding/ansi" | |||
| import "core:fmt" | |||
| import "core:strings" | |||
| import "core:os" | |||
| import "core:os/os2" | |||
There was a problem hiding this comment.
My issue with importing os2 here is that it doesn't support everything yet. You might have to split file_console_logger.odin into two files. One for the platforms that support os2, and one for everything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were various issues with core:log, namely that it would silently use context.allocator behind your back. The api has been changed to allow the user to provide an interface to the creation of file/console logger and multiloggers.
Furthermore updated the language used to be more consistent with odin's naming scheme. This renames create -> make and detroy -> delete.
The old names and behaviour have been deprecated and have had their behaviour retained.
Additionally support for os2 has been added.
Documentation was added too.