Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack MDEI struct to fix issue #4407 #4474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tf2spi
Copy link
Contributor

@tf2spi tf2spi commented Nov 10, 2024

MINIDUMP_EXCEPTION_INFORMATION is expected to be packed (which is, of course, not documented by MSDN) so this packs it so that it can be used in MinidumpWriteDump.

@tf2spi
Copy link
Contributor Author

tf2spi commented Nov 10, 2024

Additional Note: I haven't looked at the AARCH64 headers for Windows yet so I don't know if that specific architecture also expects the struct to be packed or not.

@gingerBill
Copy link
Member

So it's technically not #packed but you need #max_field_align(4).

@@ -15,7 +15,7 @@ MINIDUMP_DIRECTORY :: struct {
Location: MINIDUMP_LOCATION_DESCRIPTOR,
}

MINIDUMP_EXCEPTION_INFORMATION :: struct {
MINIDUMP_EXCEPTION_INFORMATION :: struct #packed {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

struct #max_field_align(4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants