[FIX] fields: Handle invalid domains #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangOl
reviewed
Nov 16, 2023
src/util/fields.py
Outdated
| context = safe_eval(context_s or "{}", SelfPrintEvalContext(), nocopy=True) | ||
| except SyntaxError: | ||
| cr.execute("DELETE FROM ir_filters WHERE id = %s", [id_]) | ||
| add_to_migration_reports(("ir.filters", id_, name), "Filters/Dashboards") |
There was a problem hiding this comment.
The report actually says that the filter has been corrected.
It also adds a 404 link to the removed record.
Also, why removing the filter? I would simply skip it (with a logger.warning).
KangOl
reviewed
Nov 16, 2023
src/util/fields.py
Outdated
| try: | ||
| context = safe_eval(context_s or "{}", SelfPrintEvalContext(), nocopy=True) | ||
| except SyntaxError: | ||
| cr.execute("DELETE FROM ir_filters WHERE id = %s", [id_]) |
There was a problem hiding this comment.
Suggested change
| cr.execute("DELETE FROM ir_filters WHERE id = %s", [id_]) | |
| cr.execute("DELETE FROM ir_filters WHERE id = %s", [id_]) |
Don't your editor automatically remove the trailing spaces?
|
@robodoo check |
|
I'm sorry, @xmo-odoo. I'm afraid I can't do that. |
|
@nseinlet I didn't know about this PR and had to retrieve its information, you may have to re-approve it as I didn't see previous commands. |
Some filters are simply invalid, and leads to a traceback when removing fields in them.
nseinlet
force-pushed
the
master-checkdomaincontext-nse
branch
from
717cd3f to
d1c83e4
Compare
|
upgradeci retry with always only hr project stock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some filters are simply invalid, and leads to a traceback when removing fields in them.