update(tests/decision): add more tests for better coverage

officert · Mar 30, 2020 · d79a387 · d79a387
1 parent d8a3040
commit d79a387
Show file tree

Hide file tree

Showing 6 changed files with 163 additions and 0 deletions.
diff --git a/tests/lib/client/decision/applyByAccountIdAndOrderId-test.js b/tests/lib/client/decision/applyByAccountIdAndOrderId-test.js
@@ -150,6 +150,29 @@ describe('lib', () => {
               });
           });
         });
+
+        describe('when call return an error', () => {
+          const accountId = '123';
+          const userId = '123';
+          const orderId = '123';
+          const error = new Error('Some error');
+
+
+          before('stub v3HttpClient.post()', () => {
+            sandbox.stub(v3HttpClient, 'post')
+              .returns(Promise.reject(error));
+          });
+
+          it('should also throw error if v3HttpClient.post() throw it', () => {
+            return siftScienceClient.decisions.applyByAccountIdAndOrderId(accountId, userId, orderId)
+              .then(should.not.exist)
+              .catch((err) => {
+                should.exist(err);
+                err.should.be.instanceOf(Error);
+                err.message.should.equal(error.message);
+              });
+          });
+        });
       });
     });
   });

diff --git a/tests/lib/client/decision/applyByAccountIdAndSessionId-test.js b/tests/lib/client/decision/applyByAccountIdAndSessionId-test.js
@@ -150,6 +150,29 @@ describe('lib', () => {
               });
           });
         });
+
+        describe('when call return an error', () => {
+          const accountId = '123';
+          const userId = '123';
+          const sessionId = '123';
+          const error = new Error('Some error');
+
+
+          before('stub v3HttpClient.post()', () => {
+            sandbox.stub(v3HttpClient, 'post')
+              .returns(Promise.reject(error));
+          });
+
+          it('should also throw error if v3HttpClient.post() throw it', () => {
+            return siftScienceClient.decisions.applyByAccountIdAndSessionId(accountId, userId, sessionId)
+              .then(should.not.exist)
+              .catch((err) => {
+                should.exist(err);
+                err.should.be.instanceOf(Error);
+                err.message.should.equal(error.message);
+              });
+          });
+        });
       });
     });
   });

diff --git a/tests/lib/client/decision/applyByAccountIdAndUserId-test.js b/tests/lib/client/decision/applyByAccountIdAndUserId-test.js
@@ -129,6 +129,28 @@ describe('lib', () => {
               });
           });
         });
+
+        describe('when call return an error', () => {
+          const accountId = '123';
+          const userId = '123';
+          const error = new Error('Some error');
+
+
+          before('stub v3HttpClient.post()', () => {
+            sandbox.stub(v3HttpClient, 'post')
+              .returns(Promise.reject(error));
+          });
+
+          it('should also throw error if v3HttpClient.post() throw it', () => {
+            return siftScienceClient.decisions.applyByAccountIdAndUserId(accountId, userId)
+              .then(should.not.exist)
+              .catch((err) => {
+                should.exist(err);
+                err.should.be.instanceOf(Error);
+                err.message.should.equal(error.message);
+              });
+          });
+        });
       });
     });
   });

diff --git a/tests/lib/client/decision/getByAccountIdAndOrderId-test.js b/tests/lib/client/decision/getByAccountIdAndOrderId-test.js
@@ -123,6 +123,38 @@ describe('lib', () => {
           });
         });
       });
+
+      describe('when call return an error', () => {
+        const accountId = '123';
+        const orderId = '123';
+        const error = new Error('Some error');
+
+        const key = '123';
+        let siftScienceClient;
+
+        before('create siftScienceClient', () => {
+          siftScienceClient = new SiftScienceClient(key);
+        });
+
+        before('stub v3HttpClient.get()', () => {
+          sandbox.stub(v3HttpClient, 'get')
+            .returns(Promise.reject(error));
+        });
+
+        afterEach(() => {
+          sandbox.restore();
+        });
+
+        it('should also throw error if v3HttpClient.get() throw it', () => {
+          return siftScienceClient.decisions.getByAccountIdAndOrderId(accountId, orderId)
+            .then(should.not.exist)
+            .catch((err) => {
+              should.exist(err);
+              err.should.be.instanceOf(Error);
+              err.message.should.equal(error.message);
+            });
+        });
+      });
     });
   });
 });
diff --git a/tests/lib/client/decision/getByAccountIdAndUserId-test.js b/tests/lib/client/decision/getByAccountIdAndUserId-test.js
@@ -123,6 +123,38 @@ describe('lib', () => {
           });
         });
       });
+
+      describe('when call return an error', () => {
+        const accountId = '123';
+        const userId = '123';
+        const error = new Error('Some error');
+
+        const key = '123';
+        let siftScienceClient;
+
+        before('create siftScienceClient', () => {
+          siftScienceClient = new SiftScienceClient(key);
+        });
+
+        before('stub v3HttpClient.get()', () => {
+          sandbox.stub(v3HttpClient, 'get')
+            .returns(Promise.reject(error));
+        });
+
+        afterEach(() => {
+          sandbox.restore();
+        });
+
+        it('should also throw error if v3HttpClient.get() throw it', () => {
+          return siftScienceClient.decisions.getByAccountIdAndUserId(accountId, userId)
+            .then(should.not.exist)
+            .catch((err) => {
+              should.exist(err);
+              err.should.be.instanceOf(Error);
+              err.message.should.equal(error.message);
+            });
+        });
+      });
     });
   });
 });
diff --git a/tests/lib/client/decision/listByAccountId-test.js b/tests/lib/client/decision/listByAccountId-test.js
@@ -105,6 +105,37 @@ describe('lib', () => {
               });
           });
         });
+
+        describe('when call return an error', () => {
+          const accountId = '123';
+          const error = new Error('Some error');
+
+          const key = '123';
+          let siftScienceClient;
+
+          before('create siftScienceClient', () => {
+            siftScienceClient = new SiftScienceClient(key);
+          });
+
+          before('stub v3HttpClient.get()', () => {
+            sandbox.stub(v3HttpClient, 'get')
+              .returns(Promise.reject(error));
+          });
+
+          afterEach(() => {
+            sandbox.restore();
+          });
+
+          it('should also throw error if v3HttpClient.get() throw it', () => {
+            return siftScienceClient.decisions.listByAccountId(accountId)
+              .then(should.not.exist)
+              .catch((err) => {
+                should.exist(err);
+                err.should.be.instanceOf(Error);
+                err.message.should.equal(error.message);
+              });
+          });
+        });
       });
     });
   });