Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Moving up the if position is or has been on the PV reduction" #5815

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −6
Open

Revert "Moving up the if position is or has been on the PV reduction" #5815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
391bf2b
Take 1
Viren6 Jan 19, 2025
4b7b045
Update comment
Viren6 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/search.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,10 +979,6 @@ Value Search::Worker::search(

Depth r = reduction(improving, depth, moveCount, delta);

// Decrease reduction if position is or has been on the PV (~7 Elo)
if (ss->ttPv)
r -= 1037 + (ttData.value > alpha) * 965 + (ttData.depth >= depth) * 960;

// Step 14. Pruning at shallow depth (~120 Elo).
// Depth conditions are important for mate finding.
if (!rootNode && pos.non_pawn_material(us) && !is_loss(bestValue))
Expand Down Expand Up @@ -1146,8 +1142,12 @@ Value Search::Worker::search(

// These reduction adjustments have proven non-linear scaling.
// They are optimized to time controls of 180 + 1.8 and longer,
// so changing them or adding conditions that are similar requires
// tests at these types of time controls.
// so moving them or changing them or adding conditions that are
// similar requires tests at these types of time controls.

// Decrease reduction if position is or has been on the PV (~7 Elo)
if (ss->ttPv)
r -= 1037 + (ttData.value > alpha) * 965 + (ttData.depth >= depth) * 960;

// Decrease reduction for PvNodes (~0 Elo on STC, ~2 Elo on LTC)
if (PvNode)
Expand Down
Loading