aarch64 support for cutechess-cli download (Added support for other Linux architectures for cutechess-cli download. It didn't support other than x86_64 which was by default) #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximmasiutin
changed the title
maximmasiutin
force-pushed
the
cutechess-multiarch
branch
from
f850811 to
dc659ac
Compare
|
This PR makes sense, however the link to the cutechess binary doesn't seem to work any longer. Do you still have a copy @maximmasiutin ? |
|
Actually, I see we have this repo with binaries as well https://github.com/ppigazzini/static-cutechess-cli/releases |
Sorry, don't have that any longer. I compiled the current version at that time from Github. Now we could do the same, but I see you found a repository with binaries already, so we should probably take from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fishtest didn't support other Linux machine (CPU) types to download proper binary of
cutechess-cli. It used x86_64 by default, , omitting it, to form the URL to get the file from githubusercontent.com. Therefore, for Linux x86_64 64-bit it was looking for a file namecutechess-cli-linux-64bit.zip, but on other CPUs like ARM64 it was still downloading the binary for x86_64 which could not be executed and gave error due to instructions incompatibility, preventing Fishtest worker from running.This pull request adds the machine type name (Python's
platform.machine()) to the file name if it is other than x86_64. Therefore, if the machine type is x86_64, the machine type name is not added to the file name, to maintain compatibility with earlier naming convention. Otherwise, the machine type name string is added before the architecture string, so the full name is like cutechess-cli-linux-aarch64-64bit.zipP.S. Please make the file
cutechess-cli-linux-aarch64-64bit.zipavailable to download from githubusercontent.com along withcutechess-cli-linux-64bit.zip. You can compile this aarch64 (ARM64) version yourself or use the archive that I prepared - get it from https://www.masiutin.net/cutechess-cli-linux-aarch64-64bit.zip -- I tested it on Ampere Altra.