prov/cxi: Add FI_CXI_CURL_LIB_PATH #define from autoconf #10711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biddisco
force-pushed
the
cxi_curl_libpath
branch
2 times, most recently
from
f5f1311 to
7b1d3d4
Compare
This ensures that the libcurl dlopen path is correct If the user passes '--with-curl=<path>' to configure, then the dlopen of libcurl should honor that selection and use the file path passed in Signed-off-by: John Biddiscombe <[email protected]>
biddisco
force-pushed
the
cxi_curl_libpath
branch
from
7b1d3d4 to
d59bc9f
Compare
biddisco
changed the title
|
Thanks John for opening this. I'll have someone review this and provide feedback. |
heemstra
suggested changes
Jan 22, 2025
Signed-off-by: John Biddiscombe <[email protected]>
biddisco
force-pushed
the
cxi_curl_libpath
branch
from
390b9e6 to
ccbef25
Compare
heemstra
approved these changes
Jan 23, 2025
iziemba
approved these changes
Jan 23, 2025
|
@biddisco Intel CI is blocked on authentication step. Have you received the invitation to join ofiwg I sent you two days ago? |
Thanks. Just found it and accepted invite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10710
ensures libcurl dlopen path is correct
If the user passes '--with-curl=' to configure, then the dlopen of libcurl should honor that selection and use the file path passed in