add_reference support #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bryanwoods! Sorry I missed this. I'm not using this in anything currently (and I've had no requests to update it), so you're welcome to overhaul it however you want. |
|
Cool thanks -- will do (although I've gotten through my own particular issue and hope to one day get back to this ;) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oggy Are you using this gem anymore? I'm using it in a Rails 4 project and wanted to run an
add_referencemigration and couldn't, so this adds support. However, adding unit tests for it is making me run through the usual rigamarole one needs to go through when they run a 3 year old ruby project on a new machine (bumping ActiveRecord and Minitest versions led to bumping temporaries, which led to deprecations which now lead to real failures across the suite :)). Just wondering if I'm the only person on earth using this gem and if I should just go to town on it or if you have thoughts about modernizing.I hope this finds you well!