feat: Add a time style with better human readability #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet36
reviewed
Jul 27, 2023
Cargo.toml
Outdated
| @@ -32,6 +32,8 @@ term_grid = "0.2.0" | |||
| terminal_size = "0.1.16" | |||
| unicode-width = "0.1" | |||
| zoneinfo_compiled = "0.5.1" | |||
| chrono = "0.4.26" | |||
There was a problem hiding this comment.
It looks like the dependencies list should be sorted alphabetically.
planet36
reviewed
Jul 27, 2023
src/options/view.rs
Outdated
| @@ -266,6 +266,9 @@ impl TimeFormat { | |||
| else if &word == "full-iso" { | |||
| Ok(Self::FullISO) | |||
| } | |||
| else if &word == "hu" { | |||
There was a problem hiding this comment.
Yes! I also thought that after seeing nushell, exa should have come up with the idea of this PR, which was a temporary idea, so I didn't think much about it. However, now It's better to use "human" or "relative" instead.
|
This would be a good feature. The |
This was referenced Jul 29, 2023
|
Closing this since exa is unmaintained (see #1243), and this has been merged in the active fork eza. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because when using the built-in command ls of nushell, I found that it has a more readable date display, so I hope that Exa can also support it
The following is the result of running ls in a nushell
Here are the results of running exa