Skip to content

feat: External liquidity integration #1123

feat: External liquidity integration

feat: External liquidity integration #1123

Triggered via pull request January 17, 2025 23:28
Status Failure
Total duration 1m 57s
Artifacts

lint.yml

on: pull_request
Run golangci-lint
1m 49s
Run golangci-lint
Run super-linter
1m 34s
Run super-linter
Fit to window
Zoom out
Zoom in

Annotations

20 errors and 2 warnings
Run golangci-lint: oracle/types/external_liquidity.go#L11
struct field PoolId should be PoolID
Run golangci-lint: oracle/types/external_liquidity.go#L21
func parameter poolId should be poolID
Run golangci-lint: oracle/queries/elys_query.go#L26
func parameter poolId should be poolID
Run golangci-lint: oracle/types/currency.go#L14
struct field PoolId should be PoolID
Run golangci-lint: oracle/queries/elys_query.go#L59
don't use ALL_CAPS in Go names; use CamelCase
Run golangci-lint: config/config.go#L74
struct field PoolId should be PoolID
Run golangci-lint: config/config.go#L245
var poolId should be poolID
Run golangci-lint: oracle/util.go#L241
var poolId should be poolID
Run golangci-lint: oracle/oracle_test.go#L72
parameter 'ammPools' seems to be unused, consider removing or renaming it as _
Run golangci-lint: oracle/oracle_test.go#L73
parameter 'accountedPools' seems to be unused, consider removing or renaming it as _
Run golangci-lint: oracle/provider/binance.go#L257
Error return value is not checked (errcheck)
Run golangci-lint: oracle/provider/binance_order_book_store.go#L109
Error return value of `binanceProviderBookStore.SetOrderBook` is not checked (errcheck)
Run golangci-lint: oracle/provider/binance_order_book_store.go#L123
Error return value of `binanceProviderBookStore.SetOrderBook` is not checked (errcheck)
Run golangci-lint: oracle/provider/binance_order_book_store.go#L136
Error return value of `binanceProviderBookStore.SetOrderBook` is not checked (errcheck)
Run golangci-lint: oracle/types/currency.go#L14
var-naming: struct field PoolId should be PoolID (revive)
Run golangci-lint: oracle/types/external_liquidity.go#L11
var-naming: struct field PoolId should be PoolID (revive)
Run golangci-lint: oracle/types/external_liquidity.go#L21
var-naming: func parameter poolId should be poolID (revive)
Run golangci-lint: oracle/queries/elys_query.go#L26
var-naming: func parameter poolId should be poolID (revive)
Run golangci-lint: oracle/queries/elys_query.go#L59
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
Run golangci-lint: oracle/provider/crypto.go#L335
unused-parameter: parameter 'ammPools' seems to be unused, consider removing or renaming it as _ (revive)
Run super-linter
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Run golangci-lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636