Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update uniswap provider to use new websocket api #308

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

zarazan
Copy link
Contributor

@zarazan zarazan commented Nov 8, 2023

Description

  • The old uniswap provider was using a polling mechanism to retrieve prices from a product called "The Graph". This has been replaced with a websocket API similar to the osmosis and kujira APIs. It is a strait up copy paste from the osmosis provider replacing "osmosis" with "uniswap".
  • Updated the config to remove unnecessary uniswap config values

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan zarazan requested a review from a team as a code owner November 8, 2023 17:44
@zarazan zarazan added the S:backport/umee Backport changes to umee branch label Nov 8, 2023
@zarazan zarazan force-pushed the zarazan/add-ethereum-api branch from 2b10495 to 9b7fd1f Compare November 13, 2023 19:05
Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple comments but lgtm!

.golangci.yml Outdated Show resolved Hide resolved
ojo-provider-config/currency-pairs.toml Show resolved Hide resolved
@zarazan zarazan merged commit 9ca4545 into main Nov 13, 2023
15 of 16 checks passed
@zarazan zarazan deleted the zarazan/add-ethereum-api branch November 13, 2023 20:45
mergify bot pushed a commit that referenced this pull request Nov 13, 2023
* replace uniswap provider with new websocket api

(cherry picked from commit 9ca4545)

# Conflicts:
#	ojo-provider-config/endpoints.toml
#	oracle/provider/uniswap_test.go
#	umee-provider-config/currency-pairs.toml
zarazan added a commit that referenced this pull request Nov 13, 2023
#309)

* feat: Update uniswap provider to use new websocket api (#308)

* replace uniswap provider with new websocket api

(cherry picked from commit 9ca4545)

# Conflicts:
#	ojo-provider-config/endpoints.toml
#	oracle/provider/uniswap_test.go
#	umee-provider-config/currency-pairs.toml

* resolve conflicts

---------

Co-authored-by: Kyle <[email protected]>
zarazan added a commit that referenced this pull request Nov 15, 2023
#309)

* feat: Update uniswap provider to use new websocket api (#308)

* replace uniswap provider with new websocket api

(cherry picked from commit 9ca4545)

* resolve conflicts

---------

Co-authored-by: Kyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:backport/umee Backport changes to umee branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants