Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support TIA as quote for milkTIA asset #344

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

gsk967
Copy link

@gsk967 gsk967 commented Jan 23, 2024

Description

  1. Supporting TIA as a quote config

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 requested a review from a team as a code owner January 23, 2024 17:44
@gsk967 gsk967 changed the title chore: support milkTIA chore: support TIA as quote for milkTIA asset Jan 23, 2024
@adamewozniak
Copy link
Member

unit & integration tests look like known issues, merging

@adamewozniak adamewozniak merged commit 9c240bd into umee Jan 23, 2024
17 of 19 checks passed
@adamewozniak adamewozniak deleted the sai/add-milkTIA_config branch January 23, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants