Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle identity contract fork on login. #2569

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Handle identity contract fork on login. #2569

merged 2 commits into from
Jan 31, 2025

Conversation

corrideat
Copy link
Member

Closes #2564.

@corrideat corrideat requested a review from taoeffect January 30, 2025 14:18
@corrideat corrideat self-assigned this Jan 30, 2025
@cypress Cypress
Copy link

cypress bot commented Jan 30, 2025 •
edited
Loading

group-income    Run #3849

Run Properties:  status check passed Passed #3849  •  git commit 75c536d8fb ℹ️: Merge 3cd7ffe7e085e2ba8e4cdba5b3f2e2623a1ac1d2 into 35dd2a98e07f8321bea16d149fa8...
Project group-income
Branch Review 2564-failure-to-loginrecover-in-brave-browser-tab-that-had-forked
Run status status check passed Passed #3849
Run duration 10m 44s
Commit git commit 75c536d8fb ℹ️: Merge 3cd7ffe7e085e2ba8e4cdba5b3f2e2623a1ac1d2 into 35dd2a98e07f8321bea16d149fa8...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

taoeffect
taoeffect reviewed Jan 30, 2025
View reviewed changes
frontend/main.js Outdated Show resolved Hide resolved
taoeffect
taoeffect reviewed Jan 30, 2025
View reviewed changes
frontend/main.js Outdated Show resolved Hide resolved
taoeffect
taoeffect requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ready!

taoeffect
taoeffect approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @corrideat !

@taoeffect taoeffect merged commit 16893d5 into master Jan 31, 2025
4 checks passed
@taoeffect taoeffect deleted the 2564-failure-to-loginrecover-in-brave-browser-tab-that-had-forked branch January 31, 2025 19:55
@taoeffect taoeffect mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@corrideat corrideat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to login/recover in Brave browser tab that had forked
2 participants
@corrideat @taoeffect