Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2565 Resolve SASS deprecation warnings for Chelonia dashboard #2599

Conversation

SebinSong
Copy link
Collaborator

@SebinSong SebinSong commented Feb 10, 2025

closes #2565

npm run dev:dashboard no longer complain about the sass rules.

I have gone through all existing pages in the project and have not observed any style bugs or css-related runtime errors either.

@SebinSong SebinSong self-assigned this Feb 10, 2025
Copy link

cypress bot commented Feb 10, 2025

group-income    Run #3912

Run Properties:  status check passed Passed #3912  •  git commit 9449aa4e9f ℹ️: Merge 3255b3178204753f0cb10903f9a7753561f1d7fa into a64f8e02b08eb30bdce34367d721...
Project group-income
Branch Review sebin/task/#2565-resolve-sass-deprecation-for-chelonia-dashboard
Run status status check passed Passed #3912
Run duration 11m 15s
Commit git commit 9449aa4e9f ℹ️: Merge 3255b3178204753f0cb10903f9a7753561f1d7fa into a64f8e02b08eb30bdce34367d721...
Committer Sebin Song
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 114
View all changes introduced in this branch ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @SebinSong!

@taoeffect taoeffect merged commit 5922556 into master Feb 10, 2025
4 checks passed
@taoeffect taoeffect deleted the sebin/task/#2565-resolve-sass-deprecation-for-chelonia-dashboard branch February 10, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SASS deprecation warnings for Chelonia dashboard
2 participants