add exclude paths option #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denise-kao
commented
Sep 6, 2024
•
denise-kao
commented
- Add exclude paths option for Performance issue when there is no cache yet php-aop#86
- related with add exclude paths option php-aop#87
- Fix unit test
WalterWoshid
requested changes
Sep 6, 2024
| @@ -107,6 +107,11 @@ public function findFile($namespacedClass): false|string | |||
|
|
|||
| $filePath = Path::resolve($filePath); | |||
|
|
|||
| foreach ($this->options->getExcludePaths() as $path) { | |||
| if (str_starts_with($filePath, $path)) { | |||
There was a problem hiding this comment.
I think Path::resolve($path) would be better, so that relative paths and slight differences in paths match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.