Add Roadmap table #2051
Merged
Add Roadmap table #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordankoschei-okta
requested review from
KevinGhadyani-Okta,
benschell-okta and
chrispulsinelli-okta
as code owners
chrispulsinelli-okta
approved these changes
Dec 19, 2023
|
|
||
| function parseCustomDate(dateStr: string): Date { | ||
| if (dateStr.length <= 0) { | ||
| return new Date(2999, 0); |
There was a problem hiding this comment.
Curious what this is for?
There was a problem hiding this comment.
For readability, the dates are presented as "Oct '22", "Nov '23", etc. The default sorting function handles these alphabetically, which leads to an incorrect order, so this function makes it behave as expected.
In a future rewrite I'd probably store the dates as true Dates and then render them in the desired format, but for now I'll leave it as-is.
| aValue = parseCustomDate(aValue); | ||
| bValue = parseCustomDate(bValue); | ||
|
|
||
| console.log(aValue, bValue); |
There was a problem hiding this comment.
Nope, good catch!
Comment on lines
+35
to
+44
| const severity = | ||
| value === "Fully released" | ||
| ? "success" | ||
| : value === "In Labs" | ||
| ? "warning" | ||
| : value === "In progress" | ||
| ? "default" | ||
| : value === "Not started" | ||
| ? "error" | ||
| : "default"; |
There was a problem hiding this comment.
This would be better as a switch block.
Comment on lines
+51
to
+53
| Cell: ({ cell }) => { | ||
| return cell.getValue() ? cell.getValue() : "—"; | ||
| }, |
There was a problem hiding this comment.
A lot of repeated code below... perhaps extract this function out to a variable for reuse?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Hannah, we've decided the best way to provide a Roadmap table with all the needed features is to create it using our own
DataTablecomponent and then embed it in Supernova.This PR adds a Roadmap page to the Storybook sidebar, and outputs a table that can be embedded in Supernova too.
Todo:
@okta/odyssey-design-tokensand@storybook/themingout ofdevDependenciesand intodependenciesin the Storybook package.json