Fix strange width in last DataTable column #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordankoschei-okta
requested review from
KevinGhadyani-Okta,
benschell-okta and
chrispulsinelli-okta
as code owners
chrispulsinelli-okta
approved these changes
Nov 30, 2023
| @@ -456,7 +456,9 @@ const DataTable = ({ | |||
| onSortingChange: handleSortingChange, | |||
| onRowSelectionChange: handleRowSelectionChange, | |||
| enableRowActions: | |||
| hasRowReordering || rowActionButtons || rowActionMenuItems ? true : false, | |||
| hasRowReordering === true || rowActionButtons || rowActionMenuItems | |||
There was a problem hiding this comment.
Can hasRowReordering be something other than true or false?
| @@ -2352,6 +2353,7 @@ export const components = ({ | |||
| marginBlockEnd: odysseyTokens.Spacing4, | |||
| marginInline: 0, | |||
| overflowX: "auto", | |||
| display: "block !important", | |||
There was a problem hiding this comment.
Why do we need !important? Is there an MUI conflict here?
Comment on lines
+509
to
+510
| Data in this table is procedurally-generated and will change on each | ||
| page refresh. Any resemblance to real information is coincidental. |
There was a problem hiding this comment.
Is this still true, given your other PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd originally misdiagnosed this problem as the Actions column showing up whether or not there were row actions. Turns out it was the last column showing an incorrect width, fixed with some CSS fixes that coincidentally improved the table appearance. The DataTable is now always the full width of the container, and handles column resizing more elegantly than it did before.