-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inputRef on Checkbox, Radio, Select, Button, Typography and Link OKTA-670770 #2062
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1c51277
feat: forward ref for Checkbox
shuowu-okta bf18be3
feat: forward ref for Radio
shuowu-okta 408a12f
feat: forward ref for Button
shuowu-okta 8da0a38
feat: forward ref for Typography
shuowu-okta 05224db
feat: forward ref to Link
shuowu-okta f0e812e
feat: forward inputRef for Select
shuowu-okta 06b13fc
feat: update checkbox to use inputRef as prop
shuowu-okta bd1825a
feat: update Radio to use inputRef as prop
shuowu-okta 42e229f
fix: update Button story
shuowu-okta 7575fd6
fix: remove formhelper from errosrList
shuowu-okta 5810f13
fix: only expose focus for Radio
shuowu-okta a6a7ff8
fix: only expose focus on Select
shuowu-okta 40908e5
fix: typography and button
shuowu-okta ed6504a
fix: types
shuowu-okta d7f7088
fix: remove ref for button
shuowu-okta 3997570
fix: remove ref for link
shuowu-okta cfe628c
fix: diff
shuowu-okta f7431b9
fix: handle null case
shuowu-okta 359cde0
fix: resolve comments
shuowu-okta f929184
feat: clean up and add ref support to Button, Typography, and Link
trevoring-okta e3f530e
fix: reorder props in Button
trevoring-okta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Limits scope of refs that are passed in so they can only hook onto the
.focus()
method