Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Select and SearchField, take 2 #2142

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Improve Select and SearchField, take 2 #2142

merged 8 commits into from
Feb 21, 2024

Conversation

jordankoschei-okta
Copy link
Contributor

Replaces #2072

@jordankoschei-okta jordankoschei-okta requested a review from a team February 21, 2024 01:53
@jordankoschei-okta jordankoschei-okta mentioned this pull request Feb 21, 2024
Closed
chrispulsinelli-okta
chrispulsinelli-okta reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@chrispulsinelli-okta chrispulsinelli-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for you to consider.
Also, I noticed there were no new a11y tests added for this. I believe we should have some for this change in the respective component stories, no?

packages/odyssey-react-mui/src/SearchField.tsx Outdated Show resolved Hide resolved
packages/odyssey-react-mui/src/Select.tsx Show resolved Hide resolved
packages/odyssey-react-mui/src/Select.tsx Outdated Show resolved Hide resolved
packages/odyssey-react-mui/src/Select.tsx Outdated Show resolved Hide resolved
packages/odyssey-react-mui/src/Select.tsx Outdated Show resolved Hide resolved
packages/odyssey-react-mui/src/Select.tsx Outdated Show resolved Hide resolved
KevinGhadyani-Okta
KevinGhadyani-Okta reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one comment, but I'll say this is approved once you fix the TS and Linting issues.

@jordankoschei-okta jordankoschei-okta merged commit e4507f6 into main Feb 21, 2024
1 of 2 checks passed
@jordankoschei-okta jordankoschei-okta deleted the jk/polish-inputs-3 branch February 21, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinGhadyani-Okta KevinGhadyani-Okta KevinGhadyani-Okta left review comments

@chrispulsinelli-okta chrispulsinelli-okta chrispulsinelli-okta approved these changes

@benschell-okta benschell-okta Awaiting requested review from benschell-okta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordankoschei-okta @chrispulsinelli-okta @KevinGhadyani-Okta