PageTemplate and Layout component #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevoring-okta
commented
May 2, 2024
Comment on lines
-28
to
-30
| <ScopedCssBaseline> | ||
| <Story /> | ||
| </ScopedCssBaseline> |
There was a problem hiding this comment.
Talked with @bryancunningham-okta , this MUI imported ScopedCssBaseline is bringing in unwanted styles for Storybook. Not sure if we want to create a separate PR to remove it or if removing it here is fine
trevoring-okta
commented
May 3, 2024
Comment on lines
20
to
31
| type SupportedPaneRatios = | ||
| | [1] | ||
| | [1, 1] | ||
| | [1, 2] | ||
| | [2, 1] | ||
| | [1, 3] | ||
| | [3, 1] | ||
| | [1, 1, 1] | ||
| | [1, 2, 1] | ||
| | [2, 1, 1] | ||
| | [1, 1, 2] | ||
| | [1, 1, 1, 1]; |
There was a problem hiding this comment.
Open to narrowing this type to support less ratios OOTB so any new ratios can be additive
There was a problem hiding this comment.
I don't think we need these
[1, 2, 1]
[2, 1, 1]
[1, 1, 2]
|
I fixed Applitools issues and re-ran CI. I haven't had a chance to review this yet. |
| @@ -95,6 +95,7 @@ export * from "./ScreenReaderText"; | |||
| export * from "./SearchField"; | |||
| export * from "./Select"; | |||
| export * from "./Status"; | |||
| export * from "./Surface"; | |||
There was a problem hiding this comment.
Let's move this to Labs.
KevinGhadyani-Okta
approved these changes
Jun 4, 2024
KevinGhadyani-Okta
previously approved these changes
Jun 14, 2024
bryancunningham-okta
force-pushed
the
ti-OKTA-721245-layout-component
branch
from
476e72b to
28662cb
Compare
bryancunningham-okta
changed the title
packages/odyssey-storybook/.storybook/components/RemovePaddingDecorator.tsx
Outdated
Show resolved
Hide resolved
bryancunningham-okta
previously approved these changes
Jul 22, 2024
bryancunningham-okta
approved these changes
Jul 22, 2024
bryancunningham-okta
pushed a commit
that referenced
this pull request
Jul 25, 2024
OKTA-721245 feat: start layout component feat: more work on layout component feat: documentation and syntax updates fix: update to storybook and component feat: add more to Storybook fix: remove unncessary MUI ScopedCssBaseline feat: add full-width story feat(odyssey-react-mui): create surface component feat(odyssey-react-mui): create stories for Grid feat(odyssey-react-mui): remove surface styling from Grid fix: small nit fixes feat(odyssey-react-mui): panes => regions fix(odyssey-react-mui): rename components and add disclaimer fix: standardize vertical layout distance refactor: update css refactor: alphabetize the imports feat: add rudimentary responsiveness to Layout refactor: improve nested selectors refactor: update based on code review Merge branch 'main' into ti-OKTA-721245-layout-component fix: update redundant type export
bryancunningham-okta
pushed a commit
that referenced
this pull request
Jul 25, 2024
OKTA-721245 feat: start layout component feat: more work on layout component feat: documentation and syntax updates fix: update to storybook and component feat: add more to Storybook fix: remove unncessary MUI ScopedCssBaseline feat: add full-width story feat(odyssey-react-mui): create surface component feat(odyssey-react-mui): create stories for Grid feat(odyssey-react-mui): remove surface styling from Grid fix: small nit fixes feat(odyssey-react-mui): panes => regions fix(odyssey-react-mui): rename components and add disclaimer fix: standardize vertical layout distance refactor: update css refactor: alphabetize the imports feat: add rudimentary responsiveness to Layout refactor: improve nested selectors refactor: update based on code review Merge branch 'main' into ti-OKTA-721245-layout-component fix: update redundant type export
oktapp-aperture-okta bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
OKTA-753914 fix: english leak for "Close" in Autocomplete (#2291) OKTA-742653 English leak for "Close" in Autocomplete feat: pageTemplate and Layout component (#2219) OKTA-721245 feat: start layout component feat: more work on layout component feat: documentation and syntax updates fix: update to storybook and component feat: add more to Storybook fix: remove unncessary MUI ScopedCssBaseline feat: add full-width story feat(odyssey-react-mui): create surface component feat(odyssey-react-mui): create stories for Grid feat(odyssey-react-mui): remove surface styling from Grid fix: small nit fixes feat(odyssey-react-mui): panes => regions fix(odyssey-react-mui): rename components and add disclaimer fix: standardize vertical layout distance refactor: update css refactor: alphabetize the imports feat: add rudimentary responsiveness to Layout refactor: improve nested selectors refactor: update based on code review Merge branch 'main' into ti-OKTA-721245-layout-component fix: update redundant type export fix: data Table legacy improvements (#2294) OKTA-753577 feat: add max pages and max rows per page to pagination feat: add manual pagination next disabling feat: reset pagination if search or filters changes refactor: alphabetize props feat: fixing pagination bug refactor: improve pagination calculation refactor: update currentRowsCount to be non-breaking chore(odyssey-react-mui): fix Layout story margin chore(odyssey-react-mui): bump to 1.20.0. not done in main by error chore: back to 1.19.0 chore: bump back to 1.20.0 and generate changelog Merge branch 'main' into bc_backport_1.20 Merge remote-tracking branch 'origin/main' into bc_backport_1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-721245
Summary
PageTemplateandLayoutcomponentsTesting & Screenshots
Screen.Recording.2024-05-02.at.5.03.33.PM.mov