fix: re-add Status lamp variant #2224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
951
to
952
| width: ".64em", | ||
| height: ".64em", |
There was a problem hiding this comment.
Are these the styles we had previously thath you copied over?
There was a problem hiding this comment.
These were copied over, I don't love the magic number either though, I'll check it out to see if we can use a token
|
|
||
| "&::before": { | ||
| content: "''", |
There was a problem hiding this comment.
This is weird. Why are there quotes in content?
There was a problem hiding this comment.
(disclosure: this was copied from what we had implemented a few months ago)
This method is new to me too, I normally would add a space but the rationale I found was that the single quotes in content: "''"; is interpreted as empty whereas using a space adds one character of whitespace.
KevinGhadyani-Okta
previously approved these changes
Jun 4, 2024
benlister-okta
force-pushed
the
bl/re-add-status-lamp-DES-5591
branch
2 times, most recently
from
5ffdf86 to
efda111
Compare
sets width the ~8px to match figma
* build: convert from npm-run-all to concurrently * fix: updates axe-core * fix: stories don't autoplay interactions * fix: adds hack for Toast transition interaction test * build: fixes concurrently usage * fix: adjusts hack for Toast transition interaction test * fix: makes axe run wait 500ms * fix: reset many changes and returned `test-storybook` to using package.json scripts * fix: returned test-runner to having a 500ms wait before testing to finish animations * build: re-removed test:storybook
* feat: adds Hackathon code * fix(odyssey-react-mui): add test selectors(textfield, callout and tabs) * fix(odyssey-react-mui): clean up unneeded code * feat: adds testingSelectors export * fix: test trying to select correct label * feat: adds string interpolation for test selectors * fix: minor code styling * fix: work in progress * fix: updates Callout, Tabs, and TextField with `type` annotation in import * fix: fixes Tabs testing export * fix: reverted `yarn.lock` change * fix: updates some comments to include TODO * fix: added fixes from the previous branch * fix: renames /testing-selectors export * build: changed export name to /test-selectors * chore: removes unused code comment * build: fixes CI not building before running Storybook * fix: removes Hackathon notes * fix: removed unnecessary comments in featureTestSelector --------- Co-authored-by: bryancunningham-okta <[email protected]>
fix(odyssey-react-mui): add tabindex to enable menu KB navigation
to align with Figma
chore(odyssey-react-mui): generate new odyssey icons
* build: adds Bacon support * build: adjusted .bacon.yml * build: updates Bacon yaml to use scripts/ * build: updates sort order * build: queue_name is small * build: removes incorrect action in .bacon.yml * build: switches from script_name to steps in .bacon.yml * build: adds setup script to steps * build: convert all tasks to use `steps` * build: updates queue_name * build: fix yarn install setup script * build: changes semgrep to al2023 * build: adds pre-reqs to .bacon.yml * build: removes unnecessary scripts * build: convert from npm-run-all to concurrently * fix: stories don't autoplay interactions * fix: adds hack for Toast transition interaction test * build: fixes concurrently usage * fix: adjusts hack for Toast transition interaction test * fix: makes axe run wait 500ms * fix: reset many changes and returned `test-storybook` to using package.json scripts * fix: returned test-runner to having a 500ms wait before testing to finish animations * build: re-removed test:storybook * build: adds interaction and code coverage test suites to Bacon * build: updates to Bacon yml to add missing CI tasks * fix: fixing yaml rereq reference * fix: reverting bacon yaml * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * build: adds publish script for odyssey pkgs * feat: adds publish script for npm-topic * fix: updates publish script * fix: fix to lerna publish command * fix: fix to lerna publish command * fix: fix to lerna publish command * fix: fix to lerna publish command * fix: publish script to attempt to use npm * fix: publish script to attempt to use npm with tag * fix: publish script to use lerna * fix: publish script to assume unchanged files for publish * fix: logging git status * fix: publish assuming unchanged files * fix: checking registry url * fix: fixes publish script to use commit sha * fix: publish script assume unchanged for all files * fix: publish script fix * fix: publish script assume all files unchanged for lerna * fix: update select files to be marked as unchaged for lerna publish * fix: fix lerna publish command * fix: update temp version for each package * feat: adds npm-topic publish script for promotion flow * fix: fixing interaction test bacon script * fix: commenting out immutable flag on install due to typescript minor update * fix: fixes bacon scripts for build completion * fix: installs chrome headless for CI * fix: fixes command for ci tests and code coverage * fix: fixes package.json script * fix: installing playwright deps for CI run * fix: installing playwright deps * fix: install playwright deps * fix: install apt-get * fix: remove sudo command * fix: use wget to install apt-get * fix: adds docker setup for deps install * fix: adds install for apt-get * fix: re-arranging dpkg command * fix: install apt-get * fix: pulling docker image * fix: adding docker run to test * fix: adding dockerfile for storybook testing * fix: update script for dockerfile * fix: update scripts for dockerfile * fix: fixing and relocating dockerfile for test execution * fix: fixing interaction test script * fix: fixing interaction script * fix: fixing tty error * fix: cleaning up interaction script * fix: fix to interaction test bacon suite * fix: fixes code coverage bacon suite and removes dockerfile * fix: fixes unit-test suite * fix: fixes lerna test suite * fix: cleanup yarn scripts and shell scripts * fix: commenting git update-index command for publish.sh script for testing * fix: removing pre-req from publish script to test * fix: pushing modified typescript update files * fix: adding checkout to publish script for lerna * fix: additional test to publish script * fix: fix publish script * fix: adding pre-req for publish * fix: updating lock file * fix: testing bacon failure report * fix: fixing test and testing publish * fix: testing publish * fix: testing publish script * fix: fixing publish script and adding pre-req --------- Co-authored-by: Glen Fannin <[email protected]>
OKTA-725386 feat: bumps lerna version
fix(odyssey-react-mui): fix autocomplete dropdown height
* feat(odyssey-react-mui): add info variant to Status * feat(odyssey-react-mui): updated colors to match Figma * feat(odyssey-react-mui): use palette color for background * fix(odyssey-react-mui): use correct colors
* fix(odyssey-react-mui): allow multi-select. pass value to filter * fix(odyssey-react-mui): remove commented code and log * fix(odyssey-react-mui): fix type import * fix(odyssey-react-mui): wip * feat(odyssey-react-mui): cleanup and memo
OKTA-734792 build: bump lerna version Merge branch 'main' into gf-lerna-bump
OKTA-735371 fix: dialog action button issue OKTA-735371 fix: update fix: remove react import Merge branch 'main' into bl_dialog_fix
benlister-okta
force-pushed
the
bl/re-add-status-lamp-DES-5591
branch
from
efda111 to
75ea284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DES-5591
Summary
Adds the previously deprecated
Statuslampvariant. This was removed recently to simplify the style ofStatusbut we've since found use cases forlampand numerous existing uses that necessitate the style.Testing & Screenshots