Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigial lamp from status pills #2270

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jordankoschei-okta
Copy link
Contributor

By Alex's request, this PR removes the little circle from the left side of status pills, to match Figma.

@jordankoschei-okta jordankoschei-okta requested a review from a team as a code owner June 24, 2024 19:41
Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're only removing ::before, so I see no problem.

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 68388e5 into main Jul 1, 2024
2 checks passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the remove-lamp-from-status branch July 1, 2024 00:48
stephanieyoshimoto-okta pushed a commit that referenced this pull request Jul 15, 2024
OKTA-742039 feat: remove vestigial lamp from status pills
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants