English leak for "Close" in Autocomplete #2287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
One question
@KevinGhadyani-Okta or @bryancunningham-okta please take a look as well
packages/odyssey-react-mui/src/properties/odyssey-react-mui.properties
Outdated
Show resolved
Hide resolved
packages/odyssey-react-mui/src/properties/odyssey-react-mui.properties
Outdated
Show resolved
Hide resolved
KevinGhadyani-Okta
previously approved these changes
Jul 15, 2024
OKTA-735371 fix: dialog action button issue OKTA-735371 fix: update fix: remove react import Merge branch 'main' into bl_dialog_fix
OKTA-736118 fix(odyssey-react-mui): do not need to iterate values fix(odyssey-react-mui): allow custom values in Autocomplete filter
DES-5591 fix: add status lamp [DES-5591]
DES-5647 fix: rename Tile to Card fix: add deprecated annotaiton fix: memoize Tile reference fix: update story text to trigger signed commit
OKTA-732108 fix(odyssey-react-mui): allow noOptionsText and translate clear text
…es (#2255) OKTA-736216 chore(odyssey-react-mui): translations for odyssey-react-mui.properties
OKTA-737616 fix: update changelog.md
OKTA-740007 feat: add initial search prop to DataTable
OKTA-740072 feat: add backwards compatible empty state export feat: add backwards compatibility for enableWrapping fix: add deprecation comment to enableWrapping
OKTA-739874 fix(odyssey-react-mui): pass tsetId to Accordion fix(odyssey-react-mui): remove log left in error
OKTA-739511 fix: updated vulnerable packages per Snyk
OKTA-740461 feat(odyssey-react-mui): disable link text fix(odyssey-react-mui): run prettier fix(odyssey-react-mui): re-write Switch. Add status icon. Remove MUI switch reference feat(odyssey-react-mui): adding more explicit stories feat(odyssey-react-mui): create rem utils fix(odyssey-react-mui): fix type in Story
OKTA-742458 fix: add releng.yml fix: updates to 1.17.1 fix: rename releng.yml to .releng.yml Merge branch 'main' into 1.17 fix: bumps all versions to 1.17.2 feat: add initial search prop to DataTable (#2265) OKTA-740007 feat: add initial search prop to DataTable feat: add backwards compatible empty state export (#2266) OKTA-740072 feat: add backwards compatible empty state export feat: add backwards compatibility for enableWrapping fix: add deprecation comment to enableWrapping fix: patch backwards-compat features Merge remote-tracking branch 'origin/1.17' into bc_backport_1.17_main
OKTA-743165 chore(odyssey-react-mui): bump odyssey versions fix(odyssey-react-mui): use correct version
OKTA-743054 fix: update glob to v9
OKTA-742039 feat: remove vestigial lamp from status pills
OKTA-744409 chore(odyssey-react-mui): translations for odyssey-react-mui.properties
OKTA-726074 feat: add DataComponent work feat: add DataComponent stories feat: add enableWrapping for backwards compat with hasTextWrapping refactor: alphabetize all the props refactor: reorganize the imports refactor: adding translations refactor: remove negative margin from card accessory refactor: convert sx to styled wherever needed refactor: fix some missing callback deps feat: adding row expansion to stack cards feat: add proper open mechanism to stack cards feat: updating table translations refactor: replace Box with MuiBox for native flex support refactor: implement all code review feedback feat: add docs for Data View
OKTA-744900 fix(odyssey-react-mui): update changelog and versions
OKTA-737372 feat: adds new side navigation component for unified nav design add status pill, selected item, expand/collapse side nav options refactor, review comments, use odyssey tokens adds play interaction
OKTA-746694 fix(odyssey-react-mui): only apply height rules to virtualized autocomplete
OKTA-747545 chore(odyssey-react-mui): bump odyssey-react-mui version not bumped in error
stephanieyoshimoto-okta
force-pushed
the
OKTA-742653
branch
from
f4d85de to
f6afefe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-742653
Summary
Testing & Screenshots
With pseudo-loc language selected,
Before:
Now:
