Update Roadmap JSON in Storybook #2297
Conversation
benlister-okta
changed the base branch from
main
to
bl_read_only_forms_OKTA-731946
benlister-okta
changed the base branch from
bl_read_only_forms_OKTA-731946
to
main
benlister-okta
force-pushed
the
bl_roadmap_update_jul24
branch
from
aeb2edc to
1804598
Compare
| const getTooltipText = ( | ||
| defineValue: string, | ||
| designValue: string, | ||
| developValue: string, | ||
| ): string => { | ||
| let text = ""; | ||
| if (defineValue === "In progress") { | ||
| text += "Project definition in progress"; | ||
| } | ||
| if (["Complete", "In progress"].includes(designValue)) { | ||
| text += (text ? " " : "") + "Design: " + designValue; | ||
| } | ||
| if (["Complete", "In progress"].includes(developValue)) { | ||
| text += (text ? " " : "") + "Develop: " + developValue; | ||
| } | ||
| return text.trim(); | ||
| }; |
There was a problem hiding this comment.
Since this is just the roadmap page, these are optional changes.
In general, I prefer not overloading the + operator and especially not doing mutations. I would instead write this with .concat() and return to avoid mutations.
If it works and looks right, I'm not gonna say much for this PR; I just don't want bad patterns in the codebase in general. I also don't wanna waste time on code for doc pages unless it's going to be too fragile.
There was a problem hiding this comment.
Good call. Since this is pre-existing and internal only (roadmap page), I am going to tackle this later but I just created a ticket for myself for those changes. There are some other lingering things to explore in the roadmap page as well (the root cause of why it was infinitely refreshing with pagination, search, and filters enabled) so I may work on it when I do that work.
DES-6079
Summary
Update storybook roadmap page JSON with latest from July 2024.