Add Test Selector for Checkbox #2302
Conversation
| import { Typography } from "./Typography"; | ||
|
|
||
| export const CheckboxTestSelectors = { | ||
| // feature: { |
There was a problem hiding this comment.
leaving as comment because we will eventually convert this as either a label or a different selector as discussed with @KevinGhadyani-Okta
There was a problem hiding this comment.
Can we commented this as:
| // feature: { | |
| // label: ["hint"] |
That'll make it easier in the future because the API won't match the feature API.
| @@ -261,6 +262,17 @@ export const Hint: StoryObj<typeof Checkbox> = { | |||
| }, | |||
| play: async ({ canvasElement, step }) => { | |||
| await checkTheBox({ canvasElement, step })("Checkbox Hint"); | |||
| // await step("has visible hint", async () => { | |||
There was a problem hiding this comment.
currently fails because the hint is included in the label, which it should not
There was a problem hiding this comment.
@bryancunningham-okta We'll want this noted in a ticket.
For some reason, the hint is setup as part of the label and not the description in Checkbox.
There was a problem hiding this comment.
@AnirudhMani-okta Can you put a comment above it saying "This is commented because there's a separate ticket to cover this work: OKTA-XXXXXX".
There was a problem hiding this comment.
Addressed, added ticket: https://oktainc.atlassian.net/browse/OKTA-793465
AnirudhMani-okta
changed the title
AnirudhMani-okta
changed the title
AnirudhMani-okta
force-pushed
the
am-OKTA-754187-add-checkbox-testselector
branch
from
0a5db23 to
c15c07a
Compare
AnirudhMani-okta
force-pushed
the
am-OKTA-754187-add-checkbox-testselector
branch
2 times, most recently
from
58ff20c to
d0faf57
Compare
AnirudhMani-okta
force-pushed
the
am-OKTA-754187-add-checkbox-testselector
branch
from
d0faf57 to
e00b863
Compare
|
The updated Test Selectors code is merged. |
|
You'd have to merge |
OKTA-754187
Summary
Testing & Screenshots