fix: add position: relative to TopNav to fix stacking contexts #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancunningham-okta
approved these changes
Jan 17, 2025
KevinGhadyani-Okta
approved these changes
Jan 17, 2025
KevinGhadyani-Okta
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REPLACE_WITH_JIRA_TICKET_NUMBER
Summary
Things rendered inside TopNav's slotted elements currently experience a bad stacking context (they appear under content area , the topnav bottom border renders under the content area, etc). There was already
zIndex: 1which was part of the fix, but because this did not haveposition, the z-index was having no effect. This was the intended result all along.Testing & Screenshots