feat: adds advancedOption to getWithPopup #1566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
approved these changes
Jan 20, 2025
mikenachbaur-okta
approved these changes
Jan 20, 2025
| // WARNING: This resulting promise will remain pending until the user completes the flow or timeout | ||
| if (options?.monitorPopupWindow === false) { | ||
| if (!options.timeout) { | ||
| throw new AuthSdkError('`timeout` must be set when `monitorPopupWindow` is set to `false`!'); |
Comment on lines
+20
to
+22
| // `monitorPopupWindow: false` is an advance setting. Use with caution! | ||
| // When `false`, polling to determine whether or not the popup is open is perforemd. | ||
| // A `timeout` must be provided when `monitorPopupWindow` is set to `false` |
There was a problem hiding this comment.
Suggested change
| // `monitorPopupWindow: false` is an advance setting. Use with caution! | |
| // When `false`, polling to determine whether or not the popup is open is perforemd. | |
| // A `timeout` must be provided when `monitorPopupWindow` is set to `false` | |
| // `monitorPopupWindow: false` is an advanced setting. Use with caution! | |
| // When `false`, polling to determine whether or not the popup is open will not be performed. | |
| // If using this option to disable polling, a `timeout` value must also be provided. |
|
|
||
| ### Other | ||
|
|
||
| - [#1566](https://github.com/okta/okta-auth-js/pull/1566) feat: adds advance option `monitorPopupWindow` to `getWithPopup` |
There was a problem hiding this comment.
Suggested change
| - [#1566](https://github.com/okta/okta-auth-js/pull/1566) feat: adds advance option `monitorPopupWindow` to `getWithPopup` | |
| - [#1566](https://github.com/okta/okta-auth-js/pull/1566) feat: adds the advanced option `monitorPopupWindow` to `getWithPopup`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.