Add forced casting for Arrays in Remove-NullProperties (#50) #51
Conversation
This adds a forced cast inside the method that prevents Powershell from converting a single valued array to an object. This pr does not include changes to the test methods as Im not sure how the team would intend the use case to be tested Its a revisit on okta#35
|
Thank you for your contribution, @TriggerAu! I've filed an internal ticket for the team to review and prioritize. In the meantime, could you add a unit test to verify this works as expected? -If that's not available to you, that's OK.- We have UTs for this functionality here. Internal Ref: OKTA-813695 |
- Update Remove-NullPropertiesFromArray to ensure an array is always returned - Add tests to verify functionality - Fix #43
|
Hi @TriggerAu, I've included your PR in #58 with some additional changes. You will notice that instead of using Feel free to take a look at the PR, and again, thank you for contributing to the Okta PS module ⭐ |
- Update Remove-NullPropertiesFromArray to ensure an array is always returned - Add tests to verify functionality - Fix #43 Signed-off-by: Laura Rodriguez <[email protected]>
- Update Remove-NullPropertiesFromArray to ensure an array is always returned - Add tests to verify functionality - Fix #43 Signed-off-by: Laura Rodriguez <[email protected]>
- Update Remove-NullPropertiesFromArray to ensure an array is always returned - Add tests to verify functionality - Fix #43 Signed-off-by: Laura Rodriguez <[email protected]>
- Update Remove-NullPropertiesFromArray to ensure an array is always returned - Add tests to verify functionality - Fix #43 Signed-off-by: Laura Rodriguez <[email protected]>
|
Superseded by #58 |
This adds a forced cast inside the method that prevents Powershell from converting a single valued array to an object.
This pr does not include changes to the test methods as Im not sure how the team would intend the use case to be tested
Its a revisit on #35
Issue #50