Properly clear access token #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haggrip Thank you for your contribution. Before merging this change, I'd like to be sure we have unit tests covering the scenario in question. If you are in a position to add unit tests for this please feel free to do so. We will review further internally. |
|
Internal Ref#: OKTA-641384 |
This was referenced Aug 24, 2023
|
Merged to dev branch to prepare for the addition of unit tests. Will merge to master following standard process once complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the access token from request headers and cache when calling
clear_access_token. Also update the request headers inget_nextto prevent usage of old token.See issue 363 and issue 359