Skip to content

feat: rewrite of Device Service #40

feat: rewrite of Device Service

feat: rewrite of Device Service #40

Triggered via pull request September 12, 2024 18:25
Status Cancelled
Total duration 4m 15s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 13 warnings
build
Canceling since a higher priority waiting request for 'refs/pull/129/merge-build' exists
build
The operation was canceled.
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: MiniSim/AppleScript Commands/GetDevicesCommand.swift#L24
Line Length Violation: Line should be 120 characters or less; currently it has 131 characters (line_length)
lint: MiniSim/AppleScript Commands/LaunchDeviceCommand.swift#L21
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
lint: MiniSim/Views/About.swift#L61
Trailing Closure Violation: Trailing closure syntax should be used whenever possible (trailing_closure)
lint: MiniSim/Menu.swift#L12
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 254 lines (type_body_length)
lint: MiniSim/Service/ActionFactory.swift#L51
Trailing Newline Violation: Files should have a single trailing newline (trailing_newline)
lint: MiniSim/Service/DeviceServiceFactory.swift#L3
Convenience Type Violation: Types used for hosting only static members should be implemented as a caseless enum to avoid instantiation (convenience_type)
lint: MiniSim/Service/AppleUtils.swift#L3
Convenience Type Violation: Types used for hosting only static members should be implemented as a caseless enum to avoid instantiation (convenience_type)
lint: MiniSim/Service/ActionExecutor.swift#L2
Sorted Imports Violation: Imports should be sorted (sorted_imports)
lint: MiniSim/Service/CustomCommandService.swift#L3
Convenience Type Violation: Types used for hosting only static members should be implemented as a caseless enum to avoid instantiation (convenience_type)
lint: MiniSim/Model/Platform.swift#L15
Todo Violation: TODOs should be resolved (Remove this type during migrat...) (todo)
build: MiniSimTests/DeviceDiscoveryTests.swift#L56
code after 'throw' will never be executed