get innternal transactions by tracer #201
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vui-Chee
reviewed
Dec 18, 2024
Vui-Chee
reviewed
Dec 18, 2024
Comment on lines
+41
to
+43
| func init() { | ||
| register("okTracer", NewOKTracer) | ||
| } |
There was a problem hiding this comment.
Is this function called anywhere? How does the tracing for EVM actually begins?
Vui-Chee
reviewed
Dec 18, 2024
Vui-Chee
reviewed
Dec 19, 2024
| From: currentTx.From.String(), | ||
| To: toAddress, | ||
| ValueWei: value.String(), | ||
| CallValueWei: hexutil.EncodeBig(value), |
There was a problem hiding this comment.
This follows core VM conversion and will display hex string.
Vui-Chee
reviewed
Dec 19, 2024
Comment on lines
+355
to
+360
| if index-2 >= 0 { | ||
| callTx.InternalIndex = *big.NewInt(int64(index - 2)) | ||
| } else { | ||
| callTx.InternalIndex = *big.NewInt(0) | ||
| log.Error("internalTxTraceToInnerTx got -ve internal index.", "index", index, "calc idx", index-2) | ||
| } |
There was a problem hiding this comment.
-2 to match previous inner tx response. And log error if somehow trace idx becomes -ve.
|
Some things to note, not all fields can be replicated due to slight differences in implementation. I will list those fields here:
|
|
There is also 1 slight issue, I do not know why 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get internal transaction by tracer