Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop comparing status code of compiler with mode if mode is Run #99

Merged
merged 2 commits into from
Jul 15, 2023

Conversation

cedihegi
Copy link
Contributor

@cedihegi cedihegi commented Jul 12, 2023

Fixes #98

@oli-obk
Copy link
Owner

oli-obk commented Jul 12, 2023

@cedihegi
Copy link
Contributor Author

I added a very simple test for it.

@oli-obk
Copy link
Owner

oli-obk commented Jul 14, 2023

CI is failing, does cargo test work for you? I think it should modify some Cargo.stderr file. You then need to commit those changes

@cedihegi
Copy link
Contributor Author

aah sorry, yes locally it worked but I didn't commit all the changes it made.
I pushed it now, and this revisioned file referring to my test too. hope it works

@oli-obk oli-obk merged commit 5b78f1a into oli-obk:main Jul 15, 2023
5 checks passed
@oli-obk
Copy link
Owner

oli-obk commented Jul 15, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

executing binaries and expecting panics
2 participants