Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SASS deprecation warning on tabulator themes #4570

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: SASS deprecation warning on tabulator themes #4570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20272a8
fix: tabulator_site theme
thisjt Sep 1, 2024
98e56dc
fix: tabulator_midnight theme empty ruleset
thisjt Sep 1, 2024
30c785f
fix: tabulator_site_dark theme mixed decls
thisjt Sep 1, 2024
bdc9382
fix: tabulator_simple theme mixed decls
thisjt Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/scss/themes/tabulator_midnight.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,9 @@ $rangeHeaderTextHighlightBackground: #000000 !default; //header text color when
border-color:#000;
background:$headerBackgroundColor;

&.tabulator-toggle-on{
// &.tabulator-toggle-on{
// background:#25682b;
}
// }

.tabulator-toggle-switch{
border-color:#000;
Expand Down
8 changes: 4 additions & 4 deletions src/scss/themes/tabulator_simple.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ $footerActiveColor:#d00 !default; //footer bottom active text color
.tabulator-calcs-holder{
background:darken($headerBackgroundColor, 5%) !important;

border-bottom:1px solid $headerSeparatorColor;

.tabulator-row{
background:darken($headerBackgroundColor, 5%) !important;
}

border-bottom:1px solid $headerSeparatorColor;
}
}

Expand All @@ -66,11 +66,11 @@ $footerActiveColor:#d00 !default; //footer bottom active text color
.tabulator-calcs-holder{
background:darken($footerBackgroundColor, 5%) !important;

border-bottom:1px solid $footerBackgroundColor;

.tabulator-row{
background:darken($footerBackgroundColor, 5%) !important;
}

border-bottom:1px solid $footerBackgroundColor;
}

.tabulator-spreadsheet-tabs{
Expand Down
12 changes: 6 additions & 6 deletions src/scss/themes/tabulator_site.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ $rangeHeaderTextHighlightBackground: #000000 !default; //header text color when
.tabulator-calcs-holder{
background:lighten($headerBackgroundColor, 10%) !important;

border-top:1px solid $rowBorderColor;
border-bottom:none;

.tabulator-row{
background:lighten($headerBackgroundColor, 10%) !important;
}

border-top:1px solid $rowBorderColor;
border-bottom:none;
}
}

Expand Down Expand Up @@ -120,13 +120,13 @@ $rangeHeaderTextHighlightBackground: #000000 !default; //header text color when

background:lighten($footerBackgroundColor, 10%) !important;

border-top:none;
border-bottom:1px solid $rowBorderColor;

.tabulator-row{
background:lighten($footerBackgroundColor, 10%) !important;
color:$headerTextColor !important;
}

border-top:none;
border-bottom:1px solid $rowBorderColor;
}

.tabulator-spreadsheet-tabs{
Expand Down
11 changes: 5 additions & 6 deletions src/scss/themes/tabulator_site_dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,12 @@ $rangeHeaderTextHighlightBackground: #000000 !default; //header text color when
.tabulator-calcs-holder{
background:lighten($headerBackgroundColor, 10%) !important;
border-top: 1px solid #393838;
border-top:1px solid $rowBorderColor;
border-bottom:none;

.tabulator-row{
background-color: #292929 !important;
}

border-top:1px solid $rowBorderColor;
border-bottom:none;
}

.tabulator-cell{
Expand Down Expand Up @@ -217,13 +216,13 @@ $rangeHeaderTextHighlightBackground: #000000 !default; //header text color when
background:lighten($footerBackgroundColor, 10%) !important;
border-bottom: 1px solid #393838;

border-top:none;
border-bottom:1px solid $rowBorderColor;

.tabulator-row{
background-color: #292929 !important;
color:$headerTextColor !important;
}

border-top:none;
border-bottom:1px solid $rowBorderColor;
}

.tabulator-spreadsheet-tabs{
Expand Down
Loading