This repository has been archived by the owner on Aug 23, 2021. It is now read-only.
Standardize metric labels and units #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this is the lables that we want to use but at least they are stadardized across the files. Also I'm not sure if this breaks anything with Matlab.
…bels. I'm not sure this is the lables that we want to use but at least they are stadardized across the files. Also I'm not sure if this breaks anything with Matlab.
|
@ZiqiDong97 @AlanDZQ We want to merge this after we get your PR in |
|
I just checked whether this change would break any NoisePage scripts. It looks like it won't break anything. If it were to break anything the problem would be in: https://github.com/cmu-db/noisepage/blob/999dea0b3b790f7ff56eec7e133ad514e3958e20/script/testing/reporting/utils.py#L4 or https://github.com/cmu-db/noisepage/blob/master/script/testing/reporting/constants.py because of calls from https://github.com/cmu-db/noisepage/blob/master/script/testing/reporting/parsers/oltpbench/summary_parser.py#L78 and https://github.com/cmu-db/noisepage/blob/master/script/testing/reporting/parsers/oltpbench/res_parser.py |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #337. I'm not sure if these are the labels that we want. I just picked one type of label and went with it. I actually think the snake case might be better. I am not sure if this breaks anything with Matlab. I also wasn't really sure how to test this. Also, the documentation is out of date https://github.com/oltpbenchmark/oltpbench/wiki#output