Update function logScalePossible for generic assay negative data (cBi…

…oPortal#5084) * Update logScalePossible for generic assay negative data * make sure that return type is always boolean * Add test for negative and positive data of type number
olzhasmukayev · Jan 16, 2025 · d705fa6 · d705fa6
1 parent afe709e
commit d705fa6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/shared/components/plots/PlotsTabUtils.spec.ts b/src/shared/components/plots/PlotsTabUtils.spec.ts
@@ -767,17 +767,28 @@ describe('PlotsTabUtils', () => {
     });
 
     describe('logScalePossible', () => {
-        it('should return true when data is type number', () => {
+        it('should return true when positive data is type number', () => {
             const axisData = ({
                 datatype: 'number',
-                data: [{ value: 1 }, { value: -2 }],
+                data: [{ value: 1 }, { value: 2 }],
             } as any) as IAxisData;
             const axisMenuSelection = ({
                 dataType: CLIN_ATTR_DATA_TYPE,
                 genericAssayDataType: DataTypeConstants.LIMITVALUE,
             } as any) as AxisMenuSelection;
             assert.isTrue(logScalePossible(axisMenuSelection, axisData));
         });
+        it('should return false when negative data is type number', () => {
+            const axisData = ({
+                datatype: 'number',
+                data: [{ value: 1 }, { value: -2 }],
+            } as any) as IAxisData;
+            const axisMenuSelection = ({
+                dataType: CLIN_ATTR_DATA_TYPE,
+                genericAssayDataType: DataTypeConstants.LIMITVALUE,
+            } as any) as AxisMenuSelection;
+            assert.isFalse(logScalePossible(axisMenuSelection, axisData));
+        });
     });
 
     describe('axisHasNegativeNumbers', () => {

diff --git a/src/shared/components/plots/PlotsTabUtils.tsx b/src/shared/components/plots/PlotsTabUtils.tsx
@@ -2583,11 +2583,12 @@ export function logScalePossible(
     ) {
         return true;
     } else if (
+        axisData &&
         isGenericAssaySelected(axisSelection) &&
         axisSelection.genericAssayDataType === DataTypeConstants.LIMITVALUE
     ) {
-        // Generic Assay numeric profile is log scale possible
-        return true;
+        // Check negative values in log scale
+        return axisHasNegativeNumbers(axisData) ? false : true;
     } else {
         // molecular profile
         return !!(