New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for multiline text and inline code blocks #5

Open

ianxm wants to merge 4 commits into omarish:master from ianxm:master

ianxm commented Jan 16, 2021

Hi. Thanks for creating and publishing this.

I'm not sure if these things are issues for you, but I made these changes for my Slack client (Slack's mac desktop client)

The Slack client wasn't reversing escaped symbols in plain strings, so < was showing up in Slack as >
multiline text blocks were being joined but the last word of a line was connected directly to the first word of the next line
inline code was being treated as code blocks
URLs were being written as HTML. I found a Slack doc that says how they want links formatted, but it didn't, so I just include the links directly.

ianxm added 4 commits

January 16, 2021 15:13


          Don't escape plain text


          Join multiline text with a space

ee904e7


          Wrap inline code blocks with a single backtick


          Don't write html links

7ca0150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet