-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install more recent versions of OMERO.py #9
Conversation
This relaxes the pinning of the OMERO.py version to allow the Prometheus exporter to keep connecting to OMERO.server instances with the latest security protocol enhancements. Without this change, the createSession() will fail Connection reset by peer and the metrics endpoint returns a Connection refused
I think OMERO.py 5.13.0 is the minimal version required in order to connect against a server set-up with the latest |
Build is green on #10 |
Maybe rebase to master to make build pass ? The #10 is merged now. |
The test is now failing, was not successful in trying to fix it. I think the service is not running. |
4854634
to
22a9e3a
Compare
@pwalczysko I was also confused how your #10 ended up passing the builds while the actions on https://github.com/ome/prod-playbooks have been consistently failing since the release of After investigation, turns out the Molecule test was not setting up a server with self-signed certificates. 22a9e3a adds the corresponding option and fixes the CI build and 194789e adds a note to the README. |
Could we maybe merge this please ? I suppose merging it would fix the tests in ome/prod-playbooks#373 and thus allow the ome/prod-playbooks#373 to be merged. Or do I get it wrong ? |
Yes I believe this is the root issue of the failing monitoring tests. We'll also need this reviewed and released to consume it in the upcoming IDR deployments |
@sbesson Re-run the tests after this PR got merged, but still failing ome/prod-playbooks#373 - what am I getting wrong please ? |
Has this been released? |
just tagged 0.3.4 |
|
This relaxes the pinning of the OMERO.py version to allow the Prometheus exporter to keep connecting to OMERO.server instances with the latest security protocol enhancements. Without this change, the createSession() will fail Connection reset by peer and the metrics endpoint returns a
Connection refused
This was discovered in the context of ome/omero-certificates#38 (review). After running the latest
omero certificates
command, the monitoring endpoint started failing for this instance. Locally, this got resolved by runningA patch release of the role will be required in order for the monitoring of next IDR deployments to remain functional with
omero-certificates 0.3.0
. Note also the Molecule CI is failing and might need to be fixed separately or as a prerequisite @pwalczysko and @khaledk2