Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install more recent versions of OMERO.py #9

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 14, 2023

This relaxes the pinning of the OMERO.py version to allow the Prometheus exporter to keep connecting to OMERO.server instances with the latest security protocol enhancements. Without this change, the createSession() will fail Connection reset by peer and the metrics endpoint returns a Connection refused

This was discovered in the context of ome/omero-certificates#38 (review). After running the latest omero certificates command, the monitoring endpoint started failing for this instance. Locally, this got resolved by running

[sbesson@test120-omeroreadonly-2 prometheus-omero-tools]$ sudo /opt/prometheus-omero-tools/venv3/bin/pip install -U omero-py
[sbesson@test120-omeroreadonly-2 prometheus-omero-tools]$ sudo systemctl restart prometheus-omero-exporter

A patch release of the role will be required in order for the monitoring of next IDR deployments to remain functional with omero-certificates 0.3.0. Note also the Molecule CI is failing and might need to be fixed separately or as a prerequisite @pwalczysko and @khaledk2

This relaxes the pinning of the OMERO.py version to allow the
Prometheus exporter to keep connecting to OMERO.server instances
with the latest security protocol enhancements. Without this change,
the createSession() will fail Connection reset by peer and the
metrics endpoint returns a Connection refused
@sbesson sbesson requested a review from jburel September 14, 2023 10:01
@sbesson
Copy link
Member Author

sbesson commented Sep 14, 2023

I think OMERO.py 5.13.0 is the minimal version required in order to connect against a server set-up with the latest omero-certificates and d882eda updates the role accordingly.
A secondary advantage of increasing the minimal version is that the new version of the role will also force an OMERO.py upgrade of existing deployments created with an older version of this role.

@pwalczysko
Copy link
Member

Build is green on #10

@pwalczysko
Copy link
Member

pwalczysko commented Sep 14, 2023

Maybe rebase to master to make build pass ? The #10 is merged now.

@pwalczysko
Copy link
Member

The test is now failing, was not successful in trying to fix it. I think the service is not running.

@sbesson
Copy link
Member Author

sbesson commented Sep 15, 2023

@pwalczysko I was also confused how your #10 ended up passing the builds while the actions on https://github.com/ome/prod-playbooks have been consistently failing since the release of omero-certificates 0.3.0.

After investigation, turns out the Molecule test was not setting up a server with self-signed certificates. 22a9e3a adds the corresponding option and fixes the CI build and 194789e adds a note to the README.

@sbesson sbesson requested a review from pwalczysko September 15, 2023 07:28
@pwalczysko
Copy link
Member

Could we maybe merge this please ? I suppose merging it would fix the tests in ome/prod-playbooks#373 and thus allow the ome/prod-playbooks#373 to be merged. Or do I get it wrong ?

cc @sbesson @jburel

@sbesson
Copy link
Member Author

sbesson commented Oct 5, 2023

Yes I believe this is the root issue of the failing monitoring tests. We'll also need this reviewed and released to consume it in the upcoming IDR deployments

@jburel jburel merged commit dba0877 into ome:master Oct 6, 2023
@pwalczysko
Copy link
Member

Yes I believe this is the root issue of the failing monitoring tests. We'll also need this reviewed and released to consume it in the upcoming IDR deployments

@sbesson Re-run the tests after this PR got merged, but still failing ome/prod-playbooks#373 - what am I getting wrong please ?

@sbesson
Copy link
Member Author

sbesson commented Oct 6, 2023

Has this been released?

@jburel
Copy link
Member

jburel commented Oct 6, 2023

just tagged 0.3.4

@pwalczysko
Copy link
Member

Run ome/action-ansible-galaxy-publish@main
  with:
    galaxy-api-key: ***
Run ansible-galaxy role import --api-key *** ${GITHUB_REPOSITORY%/*} ${GITHUB_REPOSITORY#*/}
  ansible-galaxy role import --api-key *** ${GITHUB_REPOSITORY%/*} ${GITHUB_REPOSITORY#*/}
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
ERROR! Error when finding available api versions from default (https://galaxy.ansible.com/) (HTTP Code: 403, Message: Forbidden)
Error: Process completed with exit code 1.

https://github.com/ome/ansible-role-omero-prometheus-exporter/actions/runs/6432255572/job/17467049347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants