-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sphinx_rtd_theme to docs dependencies #301
Conversation
@jburel Thanks for the pointer. Not sure if I've applied it wrong (I have |
you will need to declare it in the
|
It did not install it |
@jburel The error you had at ome/omero-scripts#187
whereas I'm seeing
at https://readthedocs.org/projects/ome-zarr/builds/21717507/ Also noticed that one of those jobs is github actions, the other is on readthedocs... |
docs/requirements.txt
Outdated
@@ -1,2 +1,2 @@ | |||
sphinx==5.3.0 | |||
sphinx_rtd_theme==1.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will avoid using an rc
you don't need it here
Hah, got there in the end! |
@joshmoore / @jburel OK to merge? |
docs/requirements.txt
Outdated
@@ -0,0 +1,7 @@ | |||
sphinx==7.1.2 | |||
sphinx-rtd-theme==1.3.0rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you pick the rc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 492b29c - I copied a template (link in the commit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you don't need the rc to get it to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't taking any chances!
But OK, removed the rc now.
@jburel - Green again - good to merge (since other PRs have failing builds just now)? |
Thanks |
Try to fix sphinx readthedocs build - similar to:
ome/omero-scripts@07e130d