Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return of default favicon if not found #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

will-moore
Copy link
Member

Fixes return of default favicon if one is not loaded from domain.

cc @francesw

To test, go to e.g. /mapr/favicon/?u=https%3A%2F%2Flod.humanatlas.io%2Fomap%2F18-lymph-node-cell-dive-ibex%2Fv1.0%2F and you should see a tiny globe icon shown on the page.

@francesw
Copy link

francesw commented Oct 3, 2024

looks good on the pilot
Screenshot 2024-10-03 at 16 04 50

@will-moore
Copy link
Member Author

Test above was deployed on pilot idr0159:

sudo /opt/omero/web/venv3/bin/pip uninstall -y omero-mapr
sudo /opt/omero/web/venv3/bin/pip install git+https://github.com/ome/omero-mapr.git@refs/pull/86/head
sudo service omero-web restart

looking at images from idr0158...

@dominikl
Copy link
Member

dominikl commented Oct 7, 2024

👍 Looks good, thanks Will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants