Integration tests: call pytest directly #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd4f657.
sbesson
force-pushed
the
pytest_logging
branch
from
2a00d9e
to
d28cac7
Compare
sbesson
force-pushed
the
pytest_logging
branch
from
d28cac7
to
1b83ac9
Compare
will-moore
reviewed
Jan 31, 2024
| o = self.invoke(capfd) | ||
| assert "FileAnnotation:" not in o | ||
| assert o == "" | ||
| assert len(o.strip()) == 0 |
There was a problem hiding this comment.
This 2nd assert seems redundant since you're already checked that o == ""?
There was a problem hiding this comment.
The tests have been restored to their previous state before cd4f657 but I agree the second assert feels likely superfluous and could be pushed away if we wish so
will-moore
approved these changes
Jan 31, 2024
|
A side-note that these changes also include the removal of the Combined with the release of OMERO.py 5.19.0, this should make this plugin functional with Python 3.12.0. Adding it to the overarching GitHub projects tracking the various locations to update/review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #84 (comment)
Following the upgrade of the test infrastructure to Rocky Linux 9/Python 3.9 (see ome/omero-test-infra#66), some of the tests started failing due to the presence of logging statements in the stdout conflicting with some of the
assertchecks.After some investigation, this behavioral change does not look to be related to the operating system or Python version per se but is more specific to the testing infrastructure.
These changes depend on ome/omero-test-infra#68 to call
pytestdirectly instead ofpython setup.py testand revert a11343c.