Refactor: IProject: add getter and setter of Segmenter and removal of static fileds of the objects in Core class #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
miurahr
commented
Nov 20, 2024
miurahr
commented
Nov 20, 2024
This comment was marked as outdated.
This comment was marked as outdated.
miurahr
changed the title
|
refactoring FilterMaster does not work well. I want to revert it. |
miurahr
force-pushed
the
topic/miurahr/core/project/getter-setter-segmenter
branch
from
70dbe22 to
05f4c8d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
There are unrelated refactorings. I want to skip it. |
…ject - Add getSegmenter/setSegmenter to IProject - Update Core.getSegmenter/setSegmenter to use currentProject.getSegmenter/setSegmenter Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/core/project/getter-setter-segmenter
branch
from
05f4c8d to
2bffaf0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
The test failure is happened because an aligner test uses |
- Allow Aligner to have segmenter object without depending Core.getSegmenter() - Aligner should works without loading project, so it should have its own object - Aligner also have a feature to call SegmentationCustomizer, so when user customize the segmenter, Aligner uses new one. - SegmentetionCustomizer saves customized SRX as user preference and store it in the project, so Aligner do not need to call Core.setSegmenter() Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
…egmenter Signed-off-by: Hiroshi Miura <[email protected]> # Conflicts: # aligner/src/main/java/org/omegat/gui/align/AlignPanelController.java # aligner/src/main/java/org/omegat/gui/align/Aligner.java
|
The issue in Aligner is dealt with #1190. Now merge it. |
miurahr
commented
Nov 24, 2024
…project Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move segmenter object to be hold by RealProject object.
There are Preferences and configurations of SRX in User preferences and project-specific custom segmentation rules.
There is a segmenter object which is for the current live project, which is runtime property of the live project.
Current implementation hold the segmenter in the Core class as static field.
Here propose it to move into RealProject class, and extend IProject interface to have getter and setter of the segmenter.
Pull request type
refactoring
Which ticket is resolved?
Discussed on DEV-ML thread
What does this PR change?
* removal of static fileds of segmenter
* removal of initialization of these fields in initilizeGuiImpl method
* Update getters to return value from
currentProject#getSegmenter* Update setters as well
* We don't need to reset Core static fields value when closing project.
* Removal of
Core.setSegmenter. We define private filed of the test class for these objects.* We extend mock project class with these private fields
* These changes make the test case does not depend on the static context, so there will be no interference among test cases.
AlignFilesCallbackctor to take segmenter object.* the callback object does not depend on static context of the OmegaT project.
* We can test
ExternalTMFactorywithout Core static context.Other information