Linearise message length padding #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same padding method as submitted to Conversations
Current coverage is 69.00%@@ master #12 diff @@
==========================================
Files 13 13
Lines 584 584
Methods 0 0
Messages 0 0
Branches 46 46
==========================================
Hits 403 403
Misses 167 167
Partials 14 14
|
|
Any other thoughts on this? Good/bad? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To standardise the way that message length padding is done this patch makes it the same as the one I've submitted to the Conversations app. Hence any adversary only sees the same message lengths and can't infer anything from relative comparisons.
See https://github.com/siacs/Conversations/pull/1926