Removed PHP 7.1 from PHP coding standard worflow.

omise · Aug 22, 2024 · d74d2ae · d74d2ae
1 parent b684836
commit d74d2ae
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/.github/workflows/coding-standard-check.yml b/.github/workflows/coding-standard-check.yml
@@ -29,7 +29,6 @@ jobs:
       fail-fast: false
       matrix:
         php-version:
-          - "7.1"
           - "7.2"
           - "7.3"
           - "7.4"

diff --git a/composer.json b/composer.json
@@ -31,7 +31,7 @@
   "require-dev": {
     "phpunit/phpunit": "^5.7 || ^9.5",
     "friendsofphp/php-cs-fixer": "^2.19.3 || ^3.9.5",
-    "phpstan/phpstan": "1.4.*",
+    "phpstan/phpstan": "1.11.0",
     "vlucas/phpdotenv": "5.5.0"
   },
   "autoload": {

diff --git a/lib/omise/res/OmiseApiResource.php b/lib/omise/res/OmiseApiResource.php
@@ -37,7 +37,7 @@ class OmiseApiResource extends OmiseObject
      */
     protected static function getInstance($publickey = null, $secretkey = null)
     {
-        $resource = new static($publickey, $secretkey); // @phpstan-ignore-line
+        $resource = new static($publickey, $secretkey);
         $className = get_class($resource);
         if (!isset(self::$instances[$className])) {
             static::$instances[$className] = $resource;
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,7 +29,6 @@ jobs: @@
           fail-fast: false
           matrix:
             php-version:
-              - "7.1"
               - "7.2"
               - "7.3"
               - "7.4"
@@ Expand Down @@